Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 805773004: Create DOMWindowStorage as a DOMWindowLifecycleObserver (Closed)

Created:
6 years ago by pilgrim_google
Modified:
6 years ago
Reviewers:
michaeln, jsbell
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Create DOMWindowStorage as a DOMWindowLifecycleObserver splits out some code from LocalDOMWindow in preparation for moving all storage-related code to modules BUG=428286 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187279

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -33 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 chunks +0 lines, -12 lines 0 comments Download
A + Source/core/storage/DOMWindowStorageController.h View 1 2 chunks +11 lines, -21 lines 0 comments Download
A Source/core/storage/DOMWindowStorageController.cpp View 1 1 chunk +54 lines, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pilgrim_google
simpler patch than previous one, just creates as DOMWindowLifecycleObserver, not DOMWindowProperty
6 years ago (2014-12-15 21:28:49 UTC) #2
michaeln
lgtm https://codereview.chromium.org/805773004/diff/1/Source/core/storage/DOMWindowStorage.cpp File Source/core/storage/DOMWindowStorage.cpp (right): https://codereview.chromium.org/805773004/diff/1/Source/core/storage/DOMWindowStorage.cpp#newcode34 Source/core/storage/DOMWindowStorage.cpp:34: DOMWindowStorage* controller = static_cast<DOMWindowStorage*>(WillBeHeapSupplement<Document>::from(document, supplementName())); I'm not familiar ...
6 years ago (2014-12-16 00:12:11 UTC) #3
pilgrim_google
On 2014/12/16 at 00:12:11, michaeln wrote: > lgtm > > https://codereview.chromium.org/805773004/diff/1/Source/core/storage/DOMWindowStorage.cpp > File Source/core/storage/DOMWindowStorage.cpp (right): ...
6 years ago (2014-12-16 16:08:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805773004/20001
6 years ago (2014-12-16 16:10:59 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-16 18:14:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187279

Powered by Google App Engine
This is Rietveld 408576698