Create DOMWindowStorage as a DOMWindowLifecycleObserver

Create DOMWindowStorage as a DOMWindowLifecycleObserver

splits out some code from LocalDOMWindow in preparation for moving all storage-related code to modules

BUG=428286
TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187279

[pilgrim_google, 2014-12-15 21:28:49]

pilgrim@chromium.org changed reviewers:
+ darin@chromium.org, jsbell@chromium.org, michaeln@chromium.org

[pilgrim_google, 2014-12-15 21:28:49]

simpler patch than previous one, just creates as DOMWindowLifecycleObserver, not
DOMWindowProperty

[michaeln, 2014-12-16 00:12:11]

lgtm

https://codereview.chromium.org/805773004/diff/1/Source/core/storage/DOMWindo...
File Source/core/storage/DOMWindowStorage.cpp (right):

https://codereview.chromium.org/805773004/diff/1/Source/core/storage/DOMWindo...
Source/core/storage/DOMWindowStorage.cpp:34: DOMWindowStorage* controller =
static_cast<DOMWindowStorage*>(WillBeHeapSupplement<Document>::from(document,
supplementName()));
I'm not familiar with how 'supplements' are typically named in blink maybe the
pattern you've used is common, in which case never mind my naming nit comment.

Grokking what this new class is isn't obvious at a glance, maybe call it
DOMWindowStorageSupplement?

[pilgrim_google, 2014-12-16 16:08:20]

On 2014/12/16 at 00:12:11, michaeln wrote:
> lgtm
> 
>
https://codereview.chromium.org/805773004/diff/1/Source/core/storage/DOMWindo...
> File Source/core/storage/DOMWindowStorage.cpp (right):
> 
>
https://codereview.chromium.org/805773004/diff/1/Source/core/storage/DOMWindo...
> Source/core/storage/DOMWindowStorage.cpp:34: DOMWindowStorage* controller =
static_cast<DOMWindowStorage*>(WillBeHeapSupplement<Document>::from(document,
supplementName()));
> I'm not familiar with how 'supplements' are typically named in blink maybe the
pattern you've used is common, in which case never mind my naming nit comment.
> 
> Grokking what this new class is isn't obvious at a glance, maybe call it
DOMWindowStorageSupplement?

Ah, good point. They're typically called "FooController". See, for instance,
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Will change.

[pilgrim_google, 2014-12-16 16:10:22]

pilgrim@chromium.org changed reviewers:
- darin@chromium.org

[pilgrim_google, 2014-12-16 16:10:35]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:10:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805773004/20001

[commit-bot: I haz the power, 2014-12-16 18:14:37]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187279