Issue 805743003: Add UseCounter for SMIL animation in image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 805743003: Add UseCounter for SMIL animation in image. (Closed)

Created:
6 years ago by Erik Dahlström (inactive)

Modified:
6 years ago

Reviewers:
pdr., fs

CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add UseCounter for SMIL animation in image. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187291

Patch Set 1 #

Patch Set 2 : compilefix #

Patch Set 3 : moved counter to SVGElement::sendSVGLoadEventIfPossible #

Patch Set 4 : move to SVGImage::dataChanged instead #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	Source/core/frame/UseCounter.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/core/svg/graphics/SVGImage.cpp	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pdr.

I wish we had a way to test these. I manually verified that this works ...

6 years ago (2014-12-16 21:45:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805743003/60001

6 years ago (2014-12-16 21:45:40 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-16 21:50:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187291

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages