Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 805723003: Add type annotations to gallery/js/mosaic_mode.js. (Closed)

Created:
6 years ago by yawano
Modified:
6 years ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type annotations to gallery/js/mosaic_mode.js. BUG=433728 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "gallery/js/mosaic_mode.js" Committed: https://crrev.com/fcdfa398723720472a27b0b3f279750838d22faa Cr-Commit-Position: refs/heads/master@{#308320}

Patch Set 1 #

Patch Set 2 : Fixed annotations of Mosaic.transform. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -87 lines) Patch
M ui/file_manager/gallery/js/mosaic_mode.js View 1 45 chunks +335 lines, -87 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yawano
PTAL. Thank you!
6 years ago (2014-12-15 05:28:25 UTC) #2
yawano
tileRect and imageRect of Mosaic.transform should have allowed null values. Fixed it. PTAL. Thanks.
6 years ago (2014-12-15 05:33:16 UTC) #3
fukino
lgtm!
6 years ago (2014-12-15 05:41:23 UTC) #4
yawano
On 2014/12/15 05:41:23, fukino wrote: > lgtm! Thank you!
6 years ago (2014-12-15 05:41:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805723003/20001
6 years ago (2014-12-15 05:42:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 06:34:56 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-15 06:35:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcdfa398723720472a27b0b3f279750838d22faa
Cr-Commit-Position: refs/heads/master@{#308320}

Powered by Google App Engine
This is Rietveld 408576698