Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: Source/WebCore/platform/CrossThreadCopier.cpp

Issue 8057001: Merge 94986 - Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/platform/CrossThreadCopier.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 32
33 #include "CrossThreadCopier.h" 33 #include "CrossThreadCopier.h"
34 34
35 #include "KURL.h" 35 #include "KURL.h"
36 #include "PlatformString.h" 36 #include "PlatformString.h"
37 #include "ResourceError.h" 37 #include "ResourceError.h"
38 #include "ResourceRequest.h" 38 #include "ResourceRequest.h"
39 #include "ResourceResponse.h" 39 #include "ResourceResponse.h"
40 #include "SerializedScriptValue.h" 40 #include "SerializedScriptValue.h"
41 41
42 #include <wtf/Assertions.h>
43
42 namespace WebCore { 44 namespace WebCore {
43 45
44 CrossThreadCopierBase<false, false, KURL>::Type CrossThreadCopierBase<false, fal se, KURL>::copy(const KURL& url) 46 CrossThreadCopierBase<false, false, KURL>::Type CrossThreadCopierBase<false, fal se, KURL>::copy(const KURL& url)
45 { 47 {
46 return url.copy(); 48 return url.copy();
47 } 49 }
48 50
49 CrossThreadCopierBase<false, false, String>::Type CrossThreadCopierBase<false, f alse, String>::copy(const String& str) 51 CrossThreadCopierBase<false, false, String>::Type CrossThreadCopierBase<false, f alse, String>::copy(const String& str)
50 { 52 {
51 return str.crossThreadString(); 53 return str.crossThreadString();
52 } 54 }
53 55
54 CrossThreadCopierBase<false, false, ResourceError>::Type CrossThreadCopierBase<f alse, false, ResourceError>::copy(const ResourceError& error) 56 CrossThreadCopierBase<false, false, ResourceError>::Type CrossThreadCopierBase<f alse, false, ResourceError>::copy(const ResourceError& error)
55 { 57 {
56 return error.copy(); 58 return error.copy();
57 } 59 }
58 60
59 CrossThreadCopierBase<false, false, ResourceRequest>::Type CrossThreadCopierBase <false, false, ResourceRequest>::copy(const ResourceRequest& request) 61 CrossThreadCopierBase<false, false, ResourceRequest>::Type CrossThreadCopierBase <false, false, ResourceRequest>::copy(const ResourceRequest& request)
60 { 62 {
61 return request.copyData(); 63 return request.copyData();
62 } 64 }
63 65
64 CrossThreadCopierBase<false, false, ResourceResponse>::Type CrossThreadCopierBas e<false, false, ResourceResponse>::copy(const ResourceResponse& response) 66 CrossThreadCopierBase<false, false, ResourceResponse>::Type CrossThreadCopierBas e<false, false, ResourceResponse>::copy(const ResourceResponse& response)
65 { 67 {
66 return response.copyData(); 68 return response.copyData();
67 } 69 }
68 70
71 // Test CrossThreadCopier using COMPILE_ASSERT.
72
73 // Verify that ThreadSafeRefCounted objects get handled correctly.
74 class CopierThreadSafeRefCountedTest : public ThreadSafeRefCounted<CopierThreadS afeRefCountedTest> {
75 };
76
77 COMPILE_ASSERT((WTF::IsSameType<
78 PassRefPtr<CopierThreadSafeRefCountedTest>,
79 CrossThreadCopier<PassRefPtr<CopierThreadSafeRefCountedTest> > ::Type
80 >::value),
81 PassRefPtrTest);
82 COMPILE_ASSERT((WTF::IsSameType<
83 PassRefPtr<CopierThreadSafeRefCountedTest>,
84 CrossThreadCopier<RefPtr<CopierThreadSafeRefCountedTest> >::Ty pe
85 >::value),
86 RefPtrTest);
87 COMPILE_ASSERT((WTF::IsSameType<
88 PassRefPtr<CopierThreadSafeRefCountedTest>,
89 CrossThreadCopier<CopierThreadSafeRefCountedTest*>::Type
90 >::value),
91 RawPointerTest);
92
93
94 // Add a generic specialization which will let's us verify that no other templat e matches.
95 template<typename T> struct CrossThreadCopierBase<false, false, T> {
96 typedef int Type;
97 };
98
99 // Verify that RefCounted objects only match our generic template which exposes Type as int.
100 class CopierRefCountedTest : public RefCounted<CopierRefCountedTest> {
101 };
102
103 COMPILE_ASSERT((WTF::IsSameType<
104 int,
105 CrossThreadCopier<PassRefPtr<CopierRefCountedTest> >::Type
106 >::value),
107 PassRefPtrRefCountedTest);
108
109 COMPILE_ASSERT((WTF::IsSameType<
110 int,
111 CrossThreadCopier<RefPtr<CopierRefCountedTest> >::Type
112 >::value),
113 RefPtrRefCountedTest);
114
115 COMPILE_ASSERT((WTF::IsSameType<
116 int,
117 CrossThreadCopier<CopierRefCountedTest*>::Type
118 >::value),
119 RawPointerRefCountedTest);
120
121 // Verify that PassOwnPtr gets passed through.
122 COMPILE_ASSERT((WTF::IsSameType<
123 PassOwnPtr<float>,
124 CrossThreadCopier<PassOwnPtr<float> >::Type
125 >::value),
126 PassOwnPtrTest);
127
128 // Verify that PassOwnPtr does not get passed through.
129 COMPILE_ASSERT((WTF::IsSameType<
130 int,
131 CrossThreadCopier<OwnPtr<float> >::Type
132 >::value),
133 OwnPtrTest);
134
69 } // namespace WebCore 135 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/platform/CrossThreadCopier.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698