Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 805643003: Plugin Power Saver: Shorten exception string to "Detect content" (Closed)

Created:
6 years ago by tommycli
Modified:
6 years ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Shorten exception string to "Detect content" Current string "Detect important content" in the WebUI exceptions dialog is too long. Changing to "Detect content", which is... probably fine. I mean, before PPS, it was "Ask", which was even more meaningless. BUG=444520 Committed: https://crrev.com/529e7f1c22bbb63fa91160b8d4fc5701c2a6415c Cr-Commit-Position: refs/heads/master@{#309601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
tommycli
groby: Trivial review. Change UI string to make shorter.
6 years ago (2014-12-23 20:15:47 UTC) #2
groby-ooo-7-16
Syntactically LGTM, assuming ui-leads likes the string. (Feel free to land, but alert ui-leads to ...
6 years ago (2014-12-23 21:16:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805643003/1
6 years ago (2014-12-23 21:24:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/45584)
6 years ago (2014-12-23 21:38:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805643003/1
6 years ago (2014-12-23 21:57:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/28860)
6 years ago (2014-12-23 22:06:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805643003/1
6 years ago (2014-12-24 00:39:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-24 01:44:53 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-24 01:45:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/529e7f1c22bbb63fa91160b8d4fc5701c2a6415c
Cr-Commit-Position: refs/heads/master@{#309601}

Powered by Google App Engine
This is Rietveld 408576698