sync/test/engine/test_id_factory.h - Issue 805633004: Enable Null Syncable ID which is different than Root ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/test/engine/test_id_factory.h

Issue 805633004: Enable Null Syncable ID which is different than Root ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/test/engine/test_id_factory.h

diff --git a/sync/test/engine/test_id_factory.h b/sync/test/engine/test_id_factory.h

index 85781a72f8ee98fe6487759237ebd23553ed2053..33347297632af47b65f0bc59dffe93106f7988f7 100644

--- a/sync/test/engine/test_id_factory.h

+++ b/sync/test/engine/test_id_factory.h

@@ -20,9 +20,7 @@ class TestIdFactory {

~TestIdFactory() {}

// Get the root ID.

- static syncable::Id root() {

- return syncable::Id();

- }

+ static syncable::Id root() { return syncable::Id::GetRoot(); }

// Make an ID from a number. If the number is zero, return the root ID.

// If the number is positive, create a server ID based on the value. If

« no previous file with comments | « sync/syncable/syncable_id.cc ('k') | no next file » | no next file with comments »