sync/syncable/directory_unittest.cc - Issue 805633004: Enable Null Syncable ID which is different than Root ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/directory_unittest.cc

Issue 805633004: Enable Null Syncable ID which is different than Root ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/syncable/directory_unittest.cc

diff --git a/sync/syncable/directory_unittest.cc b/sync/syncable/directory_unittest.cc

index 6aaf054f4a567085a71299d6b2db49e819fa3e95..b891dd77ebfec388813909b4e7c438bdbcd16e5f 100644

--- a/sync/syncable/directory_unittest.cc

+++ b/sync/syncable/directory_unittest.cc

@@ -1349,7 +1349,7 @@ TEST_F(SyncableDirectoryTest, ChildrenOps) {

Entry root(&rtrans, GET_BY_ID, rtrans.root_id());

ASSERT_TRUE(root.good());

EXPECT_FALSE(dir()->HasChildren(&rtrans, rtrans.root_id()));

- EXPECT_TRUE(root.GetFirstChildId().IsRoot());

+ EXPECT_TRUE(root.GetFirstChildId().IsNull());

}

{

@@ -1392,7 +1392,7 @@ TEST_F(SyncableDirectoryTest, ChildrenOps) {

Entry root(&rtrans, GET_BY_ID, rtrans.root_id());

ASSERT_TRUE(root.good());

EXPECT_FALSE(dir()->HasChildren(&rtrans, rtrans.root_id()));

- EXPECT_TRUE(root.GetFirstChildId().IsRoot());

+ EXPECT_TRUE(root.GetFirstChildId().IsNull());

}

dir()->SaveChanges();

« no previous file with comments | « sync/syncable/directory_backing_store.cc ('k') | sync/syncable/entry_kernel.h » ('j') | no next file with comments »