Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: sync/internal_api/write_node.cc

Issue 805633004: Enable Null Syncable ID which is different than Root ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed some dependencies on SERVER_PARENT_ID Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/write_node.cc
diff --git a/sync/internal_api/write_node.cc b/sync/internal_api/write_node.cc
index b1f08725ac20d9eb8e98998d0622c557b17298a6..4aab598bc319be12c40ce307647f8e14bb4a23eb 100644
--- a/sync/internal_api/write_node.cc
+++ b/sync/internal_api/write_node.cc
@@ -461,7 +461,7 @@ bool WriteNode::SetPosition(const BaseNode& new_parent,
// Filter out redundant changes if both the parent and the predecessor match.
if (new_parent_id == entry_->GetParentId()) {
const syncable::Id& old = entry_->GetPredecessorId();
- if ((!predecessor && old.IsRoot()) ||
+ if ((!predecessor && old.IsNull()) ||
(predecessor && (old == predecessor->GetEntry()->GetId()))) {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698