sync/internal_api/sync_manager_impl_unittest.cc - Issue 805633004: Enable Null Syncable ID which is different than Root ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_manager_impl_unittest.cc

Issue 805633004: Enable Null Syncable ID which is different than Root ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed some dependencies on SERVER_PARENT_ID Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/engine/directory_update_handler_unittest.cc ('K') | « sync/internal_api/base_node.cc ('k') | sync/internal_api/sync_rollback_manager_base.cc » ('j') | sync/syncable/syncable_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/sync_manager_impl_unittest.cc

diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc

index 0f58bb93ecea86c94bc9f28c0975f6fce7727d12..7bac38da59d3e9c447dd50e69720fd868c19ab68 100644

--- a/sync/internal_api/sync_manager_impl_unittest.cc

+++ b/sync/internal_api/sync_manager_impl_unittest.cc

@@ -155,7 +155,10 @@ int64 MakeServerNodeForType(UserShare* share,

entry.PutBaseVersion(1);

entry.PutServerVersion(1);

entry.PutIsUnappliedUpdate(false);

- entry.PutServerParentId(syncable::GetNullId());

+ // TODO(stanisc): setting parent ID might be unnecessary once

+ // empty parent ID is supported.

+ entry.PutParentId(syncable::Id::GetRoot());

+ entry.PutServerParentId(syncable::Id::GetRoot());

entry.PutServerIsDir(true);

entry.PutIsDir(true);

entry.PutServerSpecifics(specifics);

« sync/engine/directory_update_handler_unittest.cc ('K') | « sync/internal_api/base_node.cc ('k') | sync/internal_api/sync_rollback_manager_base.cc » ('j') | sync/syncable/syncable_id.h » ('J')