tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py - Issue 805613002: Rename AddPage -> AddUserStory in tools/telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 805613002: Rename AddPage -> AddUserStory in tools/telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/unittest_util/page_test_test_case.py ('k') | tools/telemetry/unittest_data/test_page_set.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

index 022326c1295b1727eb3f58dc2248b04a3ce2671d..2db584e91d44d5aad2598b0e109304f6116c4d59 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

@@ -211,7 +211,7 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):

@benchmark.Disabled('android', 'mac')

def testSmoothnessTimelineBasedMeasurementForSmoke(self):

ps = self.CreateEmptyPageSet()

- ps.AddPage(TestTimelinebasedMeasurementPage(

+ ps.AddUserStory(TestTimelinebasedMeasurementPage(

ps, ps.base_dir, trigger_animation=True))

measurement = tbm_module.TimelineBasedMeasurement()

@@ -231,7 +231,7 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):

@benchmark.Disabled('android', 'mac')

def testFastTimelineBasedMeasurementForSmoke(self):

ps = self.CreateEmptyPageSet()

- ps.AddPage(TestTimelinebasedMeasurementPage(

+ ps.AddUserStory(TestTimelinebasedMeasurementPage(

ps, ps.base_dir, trigger_slow=True))

measurement = tbm_module.TimelineBasedMeasurement()

@@ -269,7 +269,7 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):

@benchmark.Disabled('android', 'win', 'mac')

def testMainthreadJankTimelineBasedMeasurement(self):

ps = self.CreateEmptyPageSet()

- ps.AddPage(TestTimelinebasedMeasurementPage(

+ ps.AddUserStory(TestTimelinebasedMeasurementPage(

ps, ps.base_dir, trigger_jank=True))

measurement = tbm_module.TimelineBasedMeasurement()

« no previous file with comments | « tools/telemetry/telemetry/unittest_util/page_test_test_case.py ('k') | tools/telemetry/unittest_data/test_page_set.py » ('j') | no next file with comments »