Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 805603002: Land Recent QUIC Changes. (Closed)

Created:
6 years ago by ramant (doing other things)
Modified:
6 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade, alyssar, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. QUIC-specific variable name change. Changes largest_observed_acked to rtt_updated in various places to be more accurate. Merge internal change: 81685775 https://codereview.chromium.org/800213002/ Changing QUIC cert selection to do VIP based selection. Used IPEndPoint as the type for server_ip in all methods ala client_ip. Ran "git cl format net" to fix formatting issues. Merge internal change: 81571450 https://codereview.chromium.org/802873002/ QUIC - Added QuicConnectionPeer::GetStats while porting the following intenal server change: Improving rtt for QUIC for 0-rtt handshakes guarded by a flag. Merge internal change: 81435895 https://codereview.chromium.org/798183002/ QUIC - use the correct type and fix the formatting fixes. Changes found while merging the following change from Peter Kasting into the internal source tree. "pkasting CL: https://codereview.chromium.org/761863002/ Clean up type usage and fix MSVC "truncated value" warnings in net/quic/. The existing code is very inconsistent about whether it uses typedefs like QuickByteCount and QuicPacketCount or whether it instead uses fundamental types like uint32, uint64, and size_t. This is not only more confusing to read, in some cases it leads to MSVC warning about "possibly truncated value" when one type is implicitly converted to another, shorter one. This attempts to fix at least some of these sorts of problems by using the typedefed types more widely when possible, or else at least the same basic types other places are already using. It also fixes various warnings by including explicit casts (sometimes with legality checks)." No functionality change. Changes to keep the code similar to internal source tree. Merge internal change: 81428557 https://codereview.chromium.org/787253005/ Use std::cbrt instead of our own CubeRoot implementation. Merge internal change: 81420733 https://codereview.chromium.org/798153002/ R=rch@chromium.org Committed: https://crrev.com/7dac4befc4743666c0fcbb92d02ccd3c1c6a8389 Cr-Commit-Position: refs/heads/master@{#308415}

Patch Set 1 #

Patch Set 2 : Fix android compile by adding cast #

Patch Set 3 : use cbrt instead of std::cbrt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -56 lines) Patch
M net/quic/congestion_control/cubic.cc View 1 2 3 chunks +13 lines, -3 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/proof_source.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/crypto/proof_source_chromium.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/proof_source_chromium.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/proof_test.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 4 chunks +13 lines, -9 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 6 chunks +13 lines, -10 lines 0 comments Download
M net/quic/quic_connection_stats.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_data_writer.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_chromium.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ramant (doing other things)
6 years ago (2014-12-13 03:57:38 UTC) #1
Ryan Hamilton
lgtm
6 years ago (2014-12-15 16:44:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805603002/20001
6 years ago (2014-12-15 18:22:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/31060) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/37755)
6 years ago (2014-12-15 18:43:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805603002/40001
6 years ago (2014-12-15 18:59:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-15 21:10:20 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-15 21:11:00 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7dac4befc4743666c0fcbb92d02ccd3c1c6a8389
Cr-Commit-Position: refs/heads/master@{#308415}

Powered by Google App Engine
This is Rietveld 408576698