Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 805593002: Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally usi… (Closed)

Created:
6 years ago by chrishenry
Modified:
6 years ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally using run_tests script). Fix a failing test from this file. Found this while fixing unit test for max_failures patch (https://codereview.chromium.org/790673005/). BUG=440101 Committed: https://crrev.com/c484a63e356fb1011b553b94612586d2084325d3 Cr-Commit-Position: refs/heads/master@{#308264}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -487 lines) Patch
D tools/telemetry/telemetry/page/page_run_end_to_end_tests.py View 1 chunk +0 lines, -485 lines 0 comments Download
A + tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
chrishenry
6 years ago (2014-12-13 02:51:57 UTC) #2
nednguyen
lgtm
6 years ago (2014-12-13 07:00:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805593002/20001
6 years ago (2014-12-13 07:01:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-13 08:16:35 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c484a63e356fb1011b553b94612586d2084325d3 Cr-Commit-Position: refs/heads/master@{#308264}
6 years ago (2014-12-13 08:17:24 UTC) #7
Andre
6 years ago (2014-12-15 04:54:50 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/802243002/ by andresantoso@chromium.org.

The reason for reverting is: Some of the newly enabled tests fail on the bots.
For example,
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/bu...
.

Powered by Google App Engine
This is Rietveld 408576698