Track referenced files of subframes in PageState.

Track referenced files of subframes in PageState.

BUG=441966
TEST=Upload a previously selected file from subframe form after restore.

Committed: https://crrev.com/babe66041ee736deead08c59e5fb1d57fe46b918
Cr-Commit-Position: refs/heads/master@{#308238}

[Charlie Reis, 2014-12-12 23:52:23]

creis@chromium.org changed reviewers:
+ japhet@chromium.org

[Charlie Reis, 2014-12-12 23:52:24]

Nate, can you take a first look?  

We could go straight to updating the serialization format, but I think we may
want to have a better sense for what OOPIF will need before doing that.  At the
moment, no one reads the list of files when reconstructing WebHistoryItems from
the PageState, so it shouldn't matter.

[Nate Chapin, 2014-12-13 00:00:46]

lgtm

[Charlie Reis, 2014-12-13 00:09:02]

creis@chromium.org changed reviewers:
+ nasko@chromium.org

[Charlie Reis, 2014-12-13 00:09:03]

Thanks!  Nasko, can you give a quick skim as well?

I'm starting a followup CL to see the implications of moving the list to
ExplodedFrameState (and changing the serialization format) for OOPIF.

[nasko, 2014-12-13 00:28:47]

LGTM with nit

https://codereview.chromium.org/805563003/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_manager_browsertest.cc
(right):

https://codereview.chromium.org/805563003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager_browsertest.cc:1602:
base::FilePath file_path;
nit: I kept on reading "file_path" as in "path to the file, but not including
the file". Alternative, change the filename to be something.html, so it is
clearer.

[Charlie Reis, 2014-12-13 01:00:08]

Thanks!

https://codereview.chromium.org/805563003/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_manager_browsertest.cc
(right):

https://codereview.chromium.org/805563003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager_browsertest.cc:1602:
base::FilePath file_path;
On 2014/12/13 00:28:47, nasko wrote:
> nit: I kept on reading "file_path" as in "path to the file, but not including
> the file". Alternative, change the filename to be something.html, so it is
> clearer.

Done.

[Charlie Reis, 2014-12-13 01:00:11]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2014-12-13 01:01:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805563003/20001

[commit-bot: I haz the power, 2014-12-13 03:26:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-13 03:27:15]

Patchset 2 (id:??) landed as
https://crrev.com/babe66041ee736deead08c59e5fb1d57fe46b918
Cr-Commit-Position: refs/heads/master@{#308238}