Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 805563002: Move unlimitedStorage permission from //chrome to //extensions (Closed)

Created:
6 years ago by James Cook
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move unlimitedStorage permission from //chrome to //extensions APIPermission::kUnlimitedStorage is used in the storage implementation in //extensions so the permission should live there. This allows app_shell to load apps with unlimitedStorage in the manifest. BUG=none TEST=existing browser_tests Committed: https://crrev.com/54fb34b1d956047601edccd3638a1edea44d9b11 Cr-Commit-Position: refs/heads/master@{#308229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
Ken, PTAL
6 years ago (2014-12-12 23:46:13 UTC) #2
Ken Rockot(use gerrit already)
lgtm - I actually just moved the permissions themselves in a recent CL and forgot ...
6 years ago (2014-12-12 23:49:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805563002/1
6 years ago (2014-12-12 23:52:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 02:31:07 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-13 02:32:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54fb34b1d956047601edccd3638a1edea44d9b11
Cr-Commit-Position: refs/heads/master@{#308229}

Powered by Google App Engine
This is Rietveld 408576698