gn: More helpful default args file

gn: More helpful default args file

BUG=441955
Committed: https://crrev.com/3863a6181578b609db991e62fa7d4d11079fd1e4
Cr-Commit-Position: refs/heads/master@{#308230}

[mdempsky, 2014-12-12 23:27:49]

mdempsky@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2014-12-12 23:29:20]

With that, lgtm.

The binary only rolls periodically so it'll take a bit before it's the one in
depot_tools.

https://codereview.chromium.org/805553002/diff/1/tools/gn/command_args.cc
File tools/gn/command_args.cc (right):

https://codereview.chromium.org/805553002/diff/1/tools/gn/command_args.cc#new...
tools/gn/command_args.cc:248: "# See \"gn args --list\" for available build
arguments.\n";
I think this has to be "gn args out/gn --list".

[mdempsky, 2014-12-12 23:41:37]

https://codereview.chromium.org/805553002/diff/1/tools/gn/command_args.cc
File tools/gn/command_args.cc (right):

https://codereview.chromium.org/805553002/diff/1/tools/gn/command_args.cc#new...
tools/gn/command_args.cc:248: "# See \"gn args --list\" for available build
arguments.\n";
On 2014/12/12 23:29:20, scottmg wrote:
> I think this has to be "gn args out/gn --list".

I changed it to

  # See "gn args <dir_name> --list" for available build arguments.

to match "gn help args".

We could theoretically interpolate |build_dir| here, but I figure this is
simpler and avoids issues if a user specifies an absolute path (could result in
a really long command) or renames the build directory (the example file won't be
updated, and embedded directory name would become stale).

[mdempsky, 2014-12-12 23:42:07]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-12-12 23:44:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805553002/20001

[scottmg, 2014-12-12 23:52:49]

lgtm

[commit-bot: I haz the power, 2014-12-13 02:38:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-13 02:38:55]

Patchset 2 (id:??) landed as
https://crrev.com/3863a6181578b609db991e62fa7d4d11079fd1e4
Cr-Commit-Position: refs/heads/master@{#308230}