tests/SkBase64Test.cpp - Issue 805543002: DM warning-free on win64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/SkBase64Test.cpp

Issue 805543002: DM warning-free on win64 (Closed) Base URL: https://skia.googlesource.com/skia.git@w64

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/SkBase64Test.cpp

diff --git a/tests/SkBase64Test.cpp b/tests/SkBase64Test.cpp

index 14ff1f7717effbc02c64a22d4c43bd8a8b79a7b6..a5347687935b282577ae89269469bb0d94906f47 100644

--- a/tests/SkBase64Test.cpp

+++ b/tests/SkBase64Test.cpp

@@ -20,7 +20,7 @@ DEF_TEST(SkBase64, reporter) {

size_t encodeLength = SkBase64::Encode(all + offset, length, NULL);

SkAutoTMalloc<char> src(encodeLength + 1);

SkBase64::Encode(all + offset, length, src.get());

- src[encodeLength] = '\0';

+ src[SkToInt(encodeLength)] = '\0';

SkBase64 tryMe;

tryMe.decode(src.get(), encodeLength);

REPORTER_ASSERT(reporter, (strcmp((const char*) (all + offset), tryMe.getData()) == 0));

« no previous file with comments | « tests/PaintTest.cpp ('k') | tests/Writer32Test.cpp » ('j') | no next file with comments »