Issue 805523002: Use C++11 nullptr in Hydrogen to replace static_cast<HValue*>(NULL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 805523002: Use C++11 nullptr in Hydrogen to replace static_cast<HValue*>(NULL) (Closed)

Created:
6 years ago by adamk

Modified:
6 years ago

Reviewers:
Benedikt Meurer, Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Use C++11 nullptr in Hydrogen to replace static_cast<HValue*>(NULL) Committed: https://crrev.com/4fb4d75db6443f0c91ebdefa66b2ad724227bd6e Cr-Commit-Position: refs/heads/master@{#25810}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -326 lines)			Patch
	M	src/code-stubs-hydrogen.cc	View		34 chunks	+80 lines, -111 lines	0 comments	Download
	M	src/hydrogen.cc	View		78 chunks	+159 lines, -215 lines	0 comments	Download

Total messages: 7 (2 generated)

adamk

Not sure if this is worth it given the state of Crankshaft, but figured I'd ...

6 years ago (2014-12-12 20:23:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805523002/1

6 years ago (2014-12-15 04:06:06 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-17 10:13:04 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4fb4d75db6443f0c91ebdefa66b2ad724227bd6e
Cr-Commit-Position: refs/heads/master@{#25810}