Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 805513003: Update Clang r223109 with new cherry-picks (Closed)

Created:
6 years ago by hans
Modified:
6 years ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
precise:/work/chromium/src@clang_roll_223108
Target Ref:
refs/pending/heads/clang_roll_223108
Project:
chromium
Visibility:
Public.

Description

Update Clang r223109 with new cherry-picks This contains fixes for http://llvm.org/PR21899 which was causing assert failures in typo correction. Cherry-picks: 223177, 223209, 223705, 224172, 224173 (Since we cannot deploy the same version twice, this sets the revision to r223108 which only differs in a test file.) BUG=431803 NOTRY=true Committed: https://crrev.com/402db406144dea24212dd659c9ecc81c4ff5f607 Cr-Commit-Position: refs/heads/master@{#308361}

Patch Set 1 #

Patch Set 2 : Remove temporary code #

Patch Set 3 : diff against the right rev #

Patch Set 4 : Fix comment on r223705 patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -1 line) Patch
M tools/clang/scripts/update.sh View 1 2 3 3 chunks +230 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
hans
Please take a look.
6 years ago (2014-12-13 21:26:01 UTC) #2
Nico
On 2014/12/13 21:26:01, hans wrote: > Please take a look. Lgtm With a mix of ...
6 years ago (2014-12-13 22:17:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805513003/60001
6 years ago (2014-12-15 14:48:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30465)
6 years ago (2014-12-15 14:51:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805513003/60001
6 years ago (2014-12-15 16:28:16 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-15 16:28:57 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-15 16:29:40 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/402db406144dea24212dd659c9ecc81c4ff5f607
Cr-Commit-Position: refs/heads/master@{#308361}

Powered by Google App Engine
This is Rietveld 408576698