Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 805503002: Add responseType='arraybuffer' support to XHR (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add responseType='arraybuffer' support to XHR Also moved existing XHR tests from tests/services to tests/framework to better match the location of the XHR code itself. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e37f6b762128596b7c6c6cf54e91434bf4875894

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Forgot to add the new test #

Patch Set 4 : Updated per ojan's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -62 lines) Patch
M sky/framework/xmlhttprequest.sky View 1 2 3 4 chunks +23 lines, -3 lines 0 comments Download
A sky/tests/framework/xmlhttprequest/empty-responseType.sky View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A sky/tests/framework/xmlhttprequest/empty-responseType-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A + sky/tests/framework/xmlhttprequest/resources/pass.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/tests/framework/xmlhttprequest/responseType.sky View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A sky/tests/framework/xmlhttprequest/responseType-expected.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + sky/tests/framework/xmlhttprequest/xhr.sky View 2 chunks +3 lines, -3 lines 0 comments Download
A + sky/tests/framework/xmlhttprequest/xhr-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/tests/framework/xmlhttprequest/xhr-relative.sky View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/tests/framework/xmlhttprequest/xhr-relative-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/tests/services/xhr.sky View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/tests/services/xhr-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/services/xhr-relative.sky View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/tests/services/xhr-relative-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel
6 years ago (2014-12-12 19:05:26 UTC) #1
eseidel
ptal
6 years ago (2014-12-12 19:08:16 UTC) #2
ojan
lgtm Feel free to fix the comments now or just add TODOs. https://codereview.chromium.org/805503002/diff/20001/sky/framework/xmlhttprequest.sky File sky/framework/xmlhttprequest.sky ...
6 years ago (2014-12-12 19:11:27 UTC) #4
eseidel
6 years ago (2014-12-12 20:03:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:20002) manually as
e37f6b762128596b7c6c6cf54e91434bf4875894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698