tools/telemetry/telemetry/page/actions/action_runner_unittest.py - Issue 805463002: Implement ubertracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/action_runner_unittest.py

Issue 805463002: Implement ubertracing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merged, added surfaceflinger unit test and fixes, addressed slamm's comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/action_runner_unittest.py

diff --git a/tools/telemetry/telemetry/page/actions/action_runner_unittest.py b/tools/telemetry/telemetry/page/actions/action_runner_unittest.py

index 43401a18f69bbbe15829ba69789fcbe9509a8184..ec097dd78bb442ea2f2af67b849a3f1afaa1b407 100644

--- a/tools/telemetry/telemetry/page/actions/action_runner_unittest.py

+++ b/tools/telemetry/telemetry/page/actions/action_runner_unittest.py

@@ -43,7 +43,7 @@ class ActionRunnerInteractionTest(tab_test_case.TabTestCase):

self.assertEqual(

1, len(records),

'Failed to issue the interaction record on the tracing timeline.'

- ' Trace data:\n%s' % repr(trace_data.EventData()))

+ ' Trace data:\n%s' % repr(trace_data._raw_data))

self.assertEqual('InteractionName', records[0].label)

for attribute_name in interaction_kwargs:

self.assertTrue(getattr(records[0], attribute_name))