tools/perf/measurements/task_execution_time.py - Issue 805463002: Implement ubertracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/task_execution_time.py

Issue 805463002: Implement ubertracing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merged, added surfaceflinger unit test and fixes, addressed slamm's comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/task_execution_time.py

diff --git a/tools/perf/measurements/task_execution_time.py b/tools/perf/measurements/task_execution_time.py

index c11f37133d42e41786496922055ffd6226a6279f..59aad1b946a478051a03971679fc84116422573f 100644

--- a/tools/perf/measurements/task_execution_time.py

+++ b/tools/perf/measurements/task_execution_time.py

@@ -40,8 +40,8 @@ class TaskExecutionTime(page_test.PageTest):

options, category_filter, self._TIME_OUT_IN_SECONDS)

def DidRunActions(self, page, tab):

- timeline_data = tab.browser.platform.tracing_controller.Stop()

- timeline_model = TimelineModel(timeline_data=timeline_data)

+ trace_data = tab.browser.platform.tracing_controller.Stop()

+ timeline_model = TimelineModel(trace_data)

self._renderer_thread = timeline_model.GetRendererThreadFromTabId(tab.id)

def ValidateAndMeasurePage(self, page, tab, results):