src/factory.cc - Issue 805453002: Introduced PropertyType ACCESSOR_FIELD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 805453002: Introduced PropertyType ACCESSOR_FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 1f6dedc022f45e6a8a7d59da729f309d9a159e45..aad0add027b9201098ffe50de6de11800fb4f987 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1592,7 +1592,7 @@ Handle<GlobalObject> Factory::NewGlobalObject(Handle<JSFunction> constructor) {

for (int i = 0; i < map->NumberOfOwnDescriptors(); i++) {

PropertyDetails details = descs->GetDetails(i);

DCHECK(details.type() == CALLBACKS); // Only accessors are expected.

- PropertyDetails d = PropertyDetails(details.attributes(), CALLBACKS, i + 1);

+ PropertyDetails d(details.attributes(), CALLBACKS, i + 1);

Handle<Name> name(descs->GetKey(i));

Handle<Object> value(descs->GetCallbacksObject(i), isolate());

Handle<PropertyCell> cell = NewPropertyCell(value);

« no previous file with comments | « src/bootstrapper.cc ('k') | src/heap-snapshot-generator.h » ('j') | no next file with comments »