Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 805393003: [Telemetry] Remove old paint-rect speed index implementation. (Closed)

Created:
6 years ago by tonyg
Modified:
5 years, 11 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove old paint-rect speed index implementation. This leaves video-based support alone. BUG=448318 Committed: https://crrev.com/40c1889471c045e20793f37a95cd70622ea30625 Cr-Commit-Position: refs/heads/master@{#312250}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make lack of video capture non-fatal #

Total comments: 1

Patch Set 3 : Report none value when not supported #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -274 lines) Patch
M tools/perf/metrics/speedindex.py View 1 2 5 chunks +19 lines, -155 lines 0 comments Download
M tools/perf/metrics/speedindex_unittest.py View 1 5 chunks +1 line, -119 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
tonyg
6 years ago (2014-12-19 22:27:19 UTC) #2
chrishenry
https://codereview.chromium.org/805393003/diff/1/tools/perf/metrics/speedindex.py File tools/perf/metrics/speedindex.py (right): https://codereview.chromium.org/805393003/diff/1/tools/perf/metrics/speedindex.py#newcode40 tools/perf/metrics/speedindex.py:40: raise NotImplementedError('SpeedIndex requires video capture support') Should this raise ...
6 years ago (2014-12-20 01:21:04 UTC) #3
tonyg
https://codereview.chromium.org/805393003/diff/1/tools/perf/metrics/speedindex.py File tools/perf/metrics/speedindex.py (right): https://codereview.chromium.org/805393003/diff/1/tools/perf/metrics/speedindex.py#newcode40 tools/perf/metrics/speedindex.py:40: raise NotImplementedError('SpeedIndex requires video capture support') On 2014/12/20 01:21:04, ...
5 years, 11 months ago (2015-01-06 21:48:27 UTC) #4
chrishenry
https://codereview.chromium.org/805393003/diff/20001/tools/perf/metrics/speedindex.py File tools/perf/metrics/speedindex.py (right): https://codereview.chromium.org/805393003/diff/20001/tools/perf/metrics/speedindex.py#newcode81 tools/perf/metrics/speedindex.py:81: 'catch paint events.')) We should still add a speed_index ...
5 years, 11 months ago (2015-01-07 01:01:36 UTC) #5
yurys
Any chance of landing this? It blocks crbug.com/448318
5 years, 11 months ago (2015-01-19 06:38:38 UTC) #7
tonyg
> We should still add a speed_index metric when video_capture is not supported and > ...
5 years, 11 months ago (2015-01-20 18:43:09 UTC) #8
chrishenry
lgtm
5 years, 11 months ago (2015-01-20 19:35:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805393003/40001
5 years, 11 months ago (2015-01-20 19:36:35 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-20 19:43:22 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 19:44:33 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/40c1889471c045e20793f37a95cd70622ea30625
Cr-Commit-Position: refs/heads/master@{#312250}

Powered by Google App Engine
This is Rietveld 408576698