Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 805343004: [WebCrypto] Test updates to not use keyUsage empty (Closed)

Created:
6 years ago by Habib Virji
Modified:
6 years ago
Reviewers:
eroman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[WebCrypto] Test updates to not use keyUsage empty Previously importKey was allowed to have keyUsage as empty. Updated spec does not allow importKey to have keyUsage as empty. This CL update tests that were still having keyUsage empty. R=eroman BUG=425646 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187518

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated test comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -472 lines) Patch
M LayoutTests/crypto/clone-ecKey-private.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/clone-ecKey-private-expected.txt View 4 chunks +0 lines, -210 lines 0 comments Download
M LayoutTests/crypto/clone-rsaHashedKey-private.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/clone-rsaHashedKey-private-expected.txt View 2 chunks +0 lines, -258 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Habib Virji
Test missed in previous CL.
6 years ago (2014-12-18 23:53:47 UTC) #1
eroman
Please change the changelist description (this is not making importKey throw a syntax error, it ...
6 years ago (2014-12-18 23:56:44 UTC) #2
eroman
https://codereview.chromium.org/805343004/diff/1/LayoutTests/crypto/clone-ecKey-private.html File LayoutTests/crypto/clone-ecKey-private.html (right): https://codereview.chromium.org/805343004/diff/1/LayoutTests/crypto/clone-ecKey-private.html#newcode24 LayoutTests/crypto/clone-ecKey-private.html:24: // Tests the 24 permutations of keys generated by: ...
6 years ago (2014-12-18 23:57:57 UTC) #3
Habib Virji
https://codereview.chromium.org/805343004/diff/1/LayoutTests/crypto/clone-ecKey-private.html File LayoutTests/crypto/clone-ecKey-private.html (right): https://codereview.chromium.org/805343004/diff/1/LayoutTests/crypto/clone-ecKey-private.html#newcode24 LayoutTests/crypto/clone-ecKey-private.html:24: // Tests the 24 permutations of keys generated by: ...
6 years ago (2014-12-19 00:02:25 UTC) #4
eroman
lgtm
6 years ago (2014-12-19 00:04:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805343004/20001
6 years ago (2014-12-19 00:05:46 UTC) #7
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years ago (2014-12-19 02:07:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805343004/20001
6 years ago (2014-12-19 10:02:16 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-19 10:02:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187518

Powered by Google App Engine
This is Rietveld 408576698