Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 805333003: Revert of [GN] Set v8_use_external_snapshot_data for the same configurations as GN. (Closed)

Created:
6 years ago by Marc Treib
Modified:
6 years ago
Reviewers:
brettw, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [GN] Set v8_use_external_snapshot_data for the same configurations as GN. (patchset #2 id:40001 of https://codereview.chromium.org/796903002/) Reason for revert: Seems to have broken the Android GN build: http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/14937 http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/14938 Original issue's description: > [GN] Set v8_use_external_snapshot_data for the same configurations as GN. > > BUG=421063 > > Committed: https://crrev.com/def2eb00493259ff297e8792fee35dc7dc2204b5 > Cr-Commit-Position: refs/heads/master@{#308779} TBR=brettw@chromium.org,rmcilroy@chromium.org NOTREECHECKS=true NOTRY=true BUG=421063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M build/module_args/v8.gni View 1 chunk +4 lines, -2 lines 0 comments Download
M net/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Marc Treib
Created Revert of [GN] Set v8_use_external_snapshot_data for the same configurations as GN.
6 years ago (2014-12-17 12:13:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805333003/1
6 years ago (2014-12-17 12:13:23 UTC) #2
commit-bot: I haz the power
Failed to apply patch for net/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
6 years ago (2014-12-17 12:14:46 UTC) #5
Marc Treib
6 years ago (2014-12-17 12:15:56 UTC) #6
rmcilroy was faster: https://codereview.chromium.org/808833003/
Closing this one.

Powered by Google App Engine
This is Rietveld 408576698