media/base/android/media_decoder_job.h - Issue 805273007: Android: Propagate sample rate change to audio decoder job

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_decoder_job.h

Issue 805273007: Android: Propagate sample rate change to audio decoder job (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved UpdateOutput() back to original location Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_codec_bridge.h ('K') | « media/base/android/media_codec_bridge.cc ('k') | media/base/android/media_decoder_job.cc » ('j') | media/base/android/video_decoder_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_decoder_job.h

diff --git a/media/base/android/media_decoder_job.h b/media/base/android/media_decoder_job.h

index 4f5f3af62d9352debaafeaf50d9307fb164e2b16..549450b756fce360ce576b27581f2970ccef9b50 100644

--- a/media/base/android/media_decoder_job.h

+++ b/media/base/android/media_decoder_job.h

@@ -231,9 +231,10 @@ class MediaDecoderJob {

// new DemuxerConfigs, or false otherwise.

virtual bool IsCodecReconfigureNeeded(const DemuxerConfigs& configs) const;

- // Update the output format from the decoder, returns true if the output

- // format changes, or false otherwise.

- virtual bool UpdateOutputFormat();

+ // Update the output format from the decoder. Runs |config_changed_cb| only if

+ // format actually changes and there are no errors. Returns false on error,

+ // true otherwise

+ virtual bool UpdateOutputFormat(const base::Closure& config_changed_cb) = 0;

// Return the index to |received_data_| that is not currently being decoded.

size_t inactive_demuxer_data_index() const {