Issue 805273003: Change FontFallbackWin to use matchFamilyStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 805273003: Change FontFallbackWin to use matchFamilyStyle (Closed)

Created:
6 years ago by eae

Modified:
6 years ago

Reviewers:
pdr.

CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Change FontFallbackWin to use matchFamilyStyle Change the windows font fallback code to use the recent matchFamilyStyle API instead of the old legacyCreateTypeface when DirectWrite is enabled. This avoids the use of the legacy API when DirectWrite is used and might help fix one of the top crash bugs where we cannot load a specific font. R=pdr@chromium.org BUG=442609 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187316

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	Source/platform/fonts/win/FontFallbackWin.cpp	View		2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pdr.

I checked this and it's sane, but I'm not an expert in this area :( ...

6 years ago (2014-12-17 00:09:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805273003/1

6 years ago (2014-12-17 00:13:11 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-17 01:19:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187316

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages