Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2546)

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.h

Issue 805263004: Oilpan: cancel MIDI permission request when prefinalizing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use a pre-finalizer instead Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webmidi/MIDIAccessInitializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccessInitializer.h
diff --git a/Source/modules/webmidi/MIDIAccessInitializer.h b/Source/modules/webmidi/MIDIAccessInitializer.h
index 6a26940101cb8511da0c1b92cc19ec0ab94b30c4..1aeee6401ea6bbee077a8380de545ff69f531a46 100644
--- a/Source/modules/webmidi/MIDIAccessInitializer.h
+++ b/Source/modules/webmidi/MIDIAccessInitializer.h
@@ -19,6 +19,9 @@ class MIDIOptions;
class ScriptState;
class MIDIAccessInitializer : public ScriptPromiseResolver, public MIDIAccessorClient {
+#if ENABLE(OILPAN)
+ USING_PRE_FINALIZER(MIDIAccessInitializer, dispose);
haraken 2014/12/19 03:47:16 Just to confirm: The reason we cannot use WeakMemb
+#endif
public:
struct PortDescriptor {
String id;
@@ -59,15 +62,15 @@ public:
SecurityOrigin* securityOrigin() const;
private:
- ScriptPromise start();
-
MIDIAccessInitializer(ScriptState*, const MIDIOptions&);
ExecutionContext* executionContext() const;
+ ScriptPromise start();
+ void dispose();
OwnPtr<MIDIAccessor> m_accessor;
- bool m_requestSysex;
Vector<PortDescriptor> m_portDescriptors;
+ bool m_requestSysex;
};
} // namespace blink
« no previous file with comments | « no previous file | Source/modules/webmidi/MIDIAccessInitializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698