Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 805263003: [turbofan] move assembly order to InstructionBlock (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] move assembly order to InstructionBlock R=titzer@chromium.org BUG= Committed: https://crrev.com/44e2dd535e5789fd27de78855e7a13a75b0d91c2 Cr-Commit-Position: refs/heads/master@{#25867}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -56 lines) Patch
M src/compiler/instruction.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/instruction.cc View 1 4 chunks +19 lines, -4 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/schedule.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/schedule.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/scheduler.cc View 5 chunks +4 lines, -22 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcarney
ptal
6 years ago (2014-12-17 14:25:09 UTC) #2
titzer
lgtm, I like that we no longer hijacking the ao_number during scheduling. https://codereview.chromium.org/805263003/diff/1/src/compiler/instruction.h File src/compiler/instruction.h ...
6 years ago (2014-12-17 14:38:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805263003/20001
6 years ago (2014-12-17 14:46:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-17 15:09:58 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-17 15:10:16 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/44e2dd535e5789fd27de78855e7a13a75b0d91c2
Cr-Commit-Position: refs/heads/master@{#25867}

Powered by Google App Engine
This is Rietveld 408576698