Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8052028: NTP: Clean up of MetricsHandler class and namespacing chrome.send messages. (Closed)

Created:
9 years, 2 months ago by Dan Beam
Modified:
9 years, 2 months ago
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

NTP: Clean up of MetricsHandler class and namespacing chrome.send messages. R=estade@chromium.org TEST=Stuff compiles and works with no regressions (might want to swap out macros with mock macros and see if we report the same stuff?). BUG=97820 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104397

Patch Set 1 #

Total comments: 1

Patch Set 2 : tried to remove dependencies of metricshandler, most still necessary in NewTabUI #

Total comments: 2

Patch Set 3 : removed whitespace and rebased #

Total comments: 3

Patch Set 4 : estade's review changes #

Patch Set 5 : rebasing changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -128 lines) Patch
M chrome/browser/resources/new_tab.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp/most_visited.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/ntp4/logging.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/most_visited_page.js View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/browser/ui/webui/ntp/metrics_handler.h View 1 2 3 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/ntp/metrics_handler.cc View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 2 3 4 4 chunks +1 line, -122 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dan Beam
http://codereview.chromium.org/8052028/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (left): http://codereview.chromium.org/8052028/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc#oldcode63 chrome/browser/ui/webui/ntp/new_tab_ui.cc:63: As far as I can tell these were never ...
9 years, 2 months ago (2011-09-28 03:12:09 UTC) #1
Dan Beam
Changing reviewer to csilv as estade is out for the rest of the week.
9 years, 2 months ago (2011-09-28 17:40:48 UTC) #2
csilv
lgtm http://codereview.chromium.org/8052028/diff/4001/chrome/browser/ui/webui/ntp/metrics_handler.h File chrome/browser/ui/webui/ntp/metrics_handler.h (right): http://codereview.chromium.org/8052028/diff/4001/chrome/browser/ui/webui/ntp/metrics_handler.h#newcode47 chrome/browser/ui/webui/ntp/metrics_handler.h:47: nit: eliminate whitespace line #47
9 years, 2 months ago (2011-09-28 23:16:29 UTC) #3
Dan Beam
http://codereview.chromium.org/8052028/diff/4001/chrome/browser/ui/webui/ntp/metrics_handler.h File chrome/browser/ui/webui/ntp/metrics_handler.h (right): http://codereview.chromium.org/8052028/diff/4001/chrome/browser/ui/webui/ntp/metrics_handler.h#newcode47 chrome/browser/ui/webui/ntp/metrics_handler.h:47: On 2011/09/28 23:16:29, csilv wrote: > nit: eliminate whitespace ...
9 years, 2 months ago (2011-09-28 23:29:39 UTC) #4
Evan Stade
yay. LGTM http://codereview.chromium.org/8052028/diff/7001/chrome/browser/ui/webui/ntp/metrics_handler.cc File chrome/browser/ui/webui/ntp/metrics_handler.cc (right): http://codereview.chromium.org/8052028/diff/7001/chrome/browser/ui/webui/ntp/metrics_handler.cc#newcode75 chrome/browser/ui/webui/ntp/metrics_handler.cc:75: // Not all new tab pages get ...
9 years, 2 months ago (2011-10-03 21:34:17 UTC) #5
Dan Beam
http://codereview.chromium.org/8052028/diff/7001/chrome/browser/ui/webui/ntp/metrics_handler.cc File chrome/browser/ui/webui/ntp/metrics_handler.cc (right): http://codereview.chromium.org/8052028/diff/7001/chrome/browser/ui/webui/ntp/metrics_handler.cc#newcode75 chrome/browser/ui/webui/ntp/metrics_handler.cc:75: // Not all new tab pages get timed. In ...
9 years, 2 months ago (2011-10-03 22:27:03 UTC) #6
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/8052028/19001
9 years, 2 months ago (2011-10-06 21:56:28 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-07 00:25:13 UTC) #8 
Change committed as 104397

Powered by Google App Engine
This is Rietveld 408576698