Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: media/base/video_decoder.h

Issue 805193006: Fix VideoDecoderShim to return correct decode_id for all codecs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/video_decoder_shim.cc ('k') | media/filters/ffmpeg_video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index d7e7a791de3d168668476cbdbd73aae22dd90ef4..505248222119b6bee0776ae428674093280b8e4b 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -78,8 +78,9 @@ class MEDIA_EXPORT VideoDecoder {
// called again).
//
// After decoding is finished the decoder calls |output_cb| specified in
- // Initialize() for each decoded frame. |output_cb| may be called before or
- // after |decode_cb|.
+ // Initialize() for each decoded frame. In general |output_cb| may be called
+ // before or after |decode_cb|, but software decoders must call |output_cb|
xhwang 2015/01/22 23:52:43 I get what you mean, but this can be complicated.
Sergey Ulanov 2015/01/23 00:19:37 Done.
+ // before calling |decode_cb|, i.e. while Decode() is pending.
//
// If |buffer| is an EOS buffer then the decoder must be flushed, i.e.
// |output_cb| must be called for each frame pending in the queue and
« no previous file with comments | « content/renderer/pepper/video_decoder_shim.cc ('k') | media/filters/ffmpeg_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698