crypto/rsa_private_key_openssl.cc - Issue 805193004: Don't allow importing non-RSA keys from crypto::RSAPrivateKey::CreateFromPrivateKeyInfo().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/rsa_private_key_openssl.cc

Issue 805193004: Don't allow importing non-RSA keys from crypto::RSAPrivateKey::CreateFromPrivateKeyInfo(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: aaand remove space Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crypto/rsa_private_key_openssl.cc

diff --git a/crypto/rsa_private_key_openssl.cc b/crypto/rsa_private_key_openssl.cc

index 3dcce675a010b8ae837e74e8f4bdfc57917e7fc1..799d0f076afaaf7b5337f04e4a3c000a4e9c1ed8 100644

--- a/crypto/rsa_private_key_openssl.cc

+++ b/crypto/rsa_private_key_openssl.cc

@@ -91,7 +91,7 @@ RSAPrivateKey* RSAPrivateKey::CreateFromPrivateKeyInfo(

scoped_ptr<RSAPrivateKey> result(new RSAPrivateKey);

result->key_ = EVP_PKCS82PKEY(p8inf.get());

- if (!result->key_)

+ if (!result->key_ || EVP_PKEY_id(result->key_) != EVP_PKEY_RSA)

return NULL;

return result.release();

« no previous file with comments | « no previous file | crypto/rsa_private_key_unittest.cc » ('j') | no next file with comments »