Issue 805193004: Don't allow importing non-RSA keys from crypto::RSAPrivateKey::CreateFromPrivateKeyInfo().

Issue 805193004: Don't allow importing non-RSA keys from crypto::RSAPrivateKey::CreateFromPrivateKeyInfo(). (Closed)

Created:
5 years, 11 months ago by eroman

Modified:
5 years, 11 months ago

Reviewers:
Ryan Sleevi, davidben

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't allow importing non-RSA keys from crypto::RSAPrivateKey::CreateFromPrivateKeyInfo(). BUG=445927 Committed: https://crrev.com/f80e193770882944c64b7c1fe580e86fd46a64c0 Cr-Commit-Position: refs/heads/master@{#309854}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	crypto/rsa_private_key_openssl.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	crypto/rsa_private_key_unittest.cc	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Total messages: 10 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805193004/1

5 years, 11 months ago (2015-01-02 19:52:48 UTC) #5

eroman

I noticed this style was inconsistent with how EC private key does it, made a ...

5 years, 11 months ago (2015-01-02 19:53:44 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805193004/40001

5 years, 11 months ago (2015-01-02 19:55:49 UTC) #8

commit-bot: I haz the power

5 years, 11 months ago (2015-01-02 21:26:32 UTC) #10

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/f80e193770882944c64b7c1fe580e86fd46a64c0
Cr-Commit-Position: refs/heads/master@{#309854}