Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 805123003: Adds capture to the mojo window_manager. (Closed)

Created:
6 years ago by Elliot Glaysher
Modified:
6 years ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds capture to the mojo window_manager. This adds a CaptureController which manages capture, puts a checkbox that makes a window have capture in the wm_flow demo, and ports the relevant unit tests for FocusController. BUG=442545 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f88a2fb808a14aabee040ed7b0999ee672d9d945

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 3

Patch Set 3 : sky comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -28 lines) Patch
M examples/wm_flow/wm/frame_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.cc View 1 5 chunks +23 lines, -2 lines 0 comments Download
M mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc View 2 chunks +16 lines, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/view.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/public/cpp/view_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/window_manager/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A services/window_manager/capture_controller.h View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A services/window_manager/capture_controller.cc View 1 2 1 chunk +105 lines, -0 lines 0 comments Download
A services/window_manager/capture_controller_observer.h View 1 chunk +21 lines, -0 lines 0 comments Download
M services/window_manager/focus_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/focus_controller.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M services/window_manager/focus_controller_unittest.cc View 1 2 8 chunks +26 lines, -5 lines 0 comments Download
M services/window_manager/view_targeter.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M services/window_manager/view_targeter_unittest.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M services/window_manager/window_manager_app.h View 6 chunks +9 lines, -0 lines 0 comments Download
M services/window_manager/window_manager_app.cc View 6 chunks +27 lines, -14 lines 0 comments Download
M services/window_manager/window_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/window_manager/window_manager_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Elliot Glaysher
6 years ago (2014-12-16 00:57:49 UTC) #2
sky
https://codereview.chromium.org/805123003/diff/20001/mojo/services/view_manager/public/cpp/view.h File mojo/services/view_manager/public/cpp/view.h (right): https://codereview.chromium.org/805123003/diff/20001/mojo/services/view_manager/public/cpp/view.h#newcode106 mojo/services/view_manager/public/cpp/view.h:106: View* GetRoot(); Inline and const_cast like we do for ...
6 years ago (2014-12-16 03:44:20 UTC) #3
Elliot Glaysher
ptal (Nuked the capture code and the associated unit test.)
6 years ago (2014-12-16 18:54:01 UTC) #4
sky
LGTM
6 years ago (2014-12-16 19:02:41 UTC) #5
Elliot Glaysher
6 years ago (2014-12-16 19:09:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f88a2fb808a14aabee040ed7b0999ee672d9d945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698