Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 805113002: Moves android specific code into android directory (Closed)

Created:
6 years ago by sky
Modified:
6 years ago
Reviewers:
DaveMoore, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Moves android specific code into android directory This moves android specific code out of the shared code and into the place that needs it. BUG=none TEST=none R=qsr@chromium.org, davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bc1184a3bd9bd18967b419fc0d18f20c01eb945a

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 4

Patch Set 3 : make_scoped_ptr #

Patch Set 4 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -241 lines) Patch
M shell/BUILD.gn View 3 chunks +5 lines, -5 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/library_loader.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M shell/android/mojo_main.h View 1 chunk +2 lines, -0 lines 0 comments Download
M shell/android/mojo_main.cc View 1 2 3 4 chunks +76 lines, -5 lines 0 comments Download
A + shell/android/ui_application_loader_android.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + shell/android/ui_application_loader_android.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M shell/context.h View 3 chunks +0 lines, -12 lines 0 comments Download
M shell/context.cc View 1 2 3 4 chunks +0 lines, -82 lines 0 comments Download
D shell/ui_application_loader_android.h View 1 chunk +0 lines, -59 lines 0 comments Download
D shell/ui_application_loader_android.cc View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sky
6 years ago (2014-12-15 23:55:20 UTC) #1
qsr
Very nice. LGTM with optional changes. https://codereview.chromium.org/805113002/diff/20001/shell/android/mojo_main.cc File shell/android/mojo_main.cc (right): https://codereview.chromium.org/805113002/diff/20001/shell/android/mojo_main.cc#newcode22 shell/android/mojo_main.cc:22: #include "mojo/application_manager/background_shell_application_loader.h" You ...
6 years ago (2014-12-16 09:20:49 UTC) #3
sky
I'm going to land what's here. I'll do a follow on patch the moves the ...
6 years ago (2014-12-16 16:30:17 UTC) #4
sky
6 years ago (2014-12-16 16:55:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
bc1184a3bd9bd18967b419fc0d18f20c01eb945a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698