Issue 805083007: Run gn check for an android build on presubmit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 805083007: Run gn check for an android build on presubmit (Closed)

Created:
6 years ago by qsr

Modified:
6 years ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Run gn check for an android build on presubmit Also, fix gn check errors. This is a reland of https://codereview.chromium.org/808703005 with some additional testing to only run gn check for android when the checkout contains the android specific dependencies. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/191805569772d5bfdc8a35329f51b4f05d27f32c

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -33 lines)			Patch
M	PRESUBMIT.py	View	2 chunks	+37 lines, -24 lines	0 comments	Download
M	examples/device_name/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/edk/embedder/BUILD.gn	View	3 chunks	+7 lines, -9 lines	0 comments	Download
M	mojo/services/network/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

qsr

6 years ago (2014-12-18 15:50:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
191805569772d5bfdc8a35329f51b4f05d27f32c (presubmit successful).

Expand Messages | Collapse Messages