just use c++ static_assert everywhere

just use c++ static_assert everywhere

We can simplify COMPILE_ASSERT, since all our toolchains
support c++'s static_assert.  This matches chromium's
definition.

BUG=442514
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187213

[Mostyn Bramley-Moore, 2014-12-15 22:34:23]

mostynb@opera.com changed reviewers:
+ thakis@chromium.org

[Mostyn Bramley-Moore, 2014-12-15 22:34:23]

@Nico: I think all our toolchains support c++'s static_assert, so we can
simplify blink's COMPILE_ASSERT.

[Nico, 2014-12-15 22:41:21]

lgtm

I always thought we'd just remove all the COMPILE_ASSERT lines and use
static_assert directly, but this is fine in the meantime

https://codereview.chromium.org/805073002/diff/1/Source/wtf/Compiler.h
File Source/wtf/Compiler.h (left):

https://codereview.chromium.org/805073002/diff/1/Source/wtf/Compiler.h#oldcode86
Source/wtf/Compiler.h:86: #if GCC_VERSION_AT_LEAST(4, 5, 0)

We require gcc 4.8, you can remove this check too

https://codereview.chromium.org/805073002/diff/1/Source/wtf/Compiler.h
File Source/wtf/Compiler.h (right):

https://codereview.chromium.org/805073002/diff/1/Source/wtf/Compiler.h#newcode74
Source/wtf/Compiler.h:74: #if COMPILER(GCC) && !COMPILER(CLANG)
Maybe the !CLANG isn't needed anymore? (not for this cl though)

[Mostyn Bramley-Moore, 2014-12-15 22:49:26]

> I always thought we'd just remove all the COMPILE_ASSERT lines and use
> static_assert directly, but this is fine in the meantime

I can make that change now if you prefer (if so I will break it down into a set
of CLs so it's easier to get reviewed).

[Nico, 2014-12-15 22:55:13]

On 2014/12/15 22:49:26, Mostyn Bramley-Moore wrote:
> > I always thought we'd just remove all the COMPILE_ASSERT lines and use
> > static_assert directly, but this is fine in the meantime
> 
> I can make that change now if you prefer

Up to you. (Or you could land this and then do the replacing.) I think it'd be
nice to use static_assert directly at some point.

[Mostyn Bramley-Moore, 2014-12-15 23:06:18]

Filed crbug.com/442514 to follow up with a switch to bare static_assert.

https://codereview.chromium.org/805073002/diff/1/Source/wtf/Compiler.h
File Source/wtf/Compiler.h (left):

https://codereview.chromium.org/805073002/diff/1/Source/wtf/Compiler.h#oldcode86
Source/wtf/Compiler.h:86: #if GCC_VERSION_AT_LEAST(4, 5, 0)
On 2014/12/15 22:41:21, Nico wrote:
> 
> We require gcc 4.8, you can remove this check too

Done.

https://codereview.chromium.org/805073002/diff/1/Source/wtf/Compiler.h
File Source/wtf/Compiler.h (right):

https://codereview.chromium.org/805073002/diff/1/Source/wtf/Compiler.h#newcode74
Source/wtf/Compiler.h:74: #if COMPILER(GCC) && !COMPILER(CLANG)
On 2014/12/15 22:41:21, Nico wrote:
> Maybe the !CLANG isn't needed anymore? (not for this cl though)

Acknowledged.  I will test it and submit another CL.

[Mostyn Bramley-Moore, 2014-12-15 23:06:35]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-12-15 23:07:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805073002/20001

[commit-bot: I haz the power, 2014-12-16 01:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 01:56:55]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41936)

[Nico, 2014-12-16 02:03:31]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-12-16 02:04:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/805073002/20001

[commit-bot: I haz the power, 2014-12-16 03:06:57]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187213