content/browser/indexed_db/leveldb/leveldb_database.cc - Issue 805043006: IndexedDB: ParseMethodAndError takes a leveldb::Status instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/leveldb/leveldb_database.cc

Issue 805043006: IndexedDB: ParseMethodAndError takes a leveldb::Status instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/indexed_db/leveldb/leveldb_database.cc

diff --git a/content/browser/indexed_db/leveldb/leveldb_database.cc b/content/browser/indexed_db/leveldb/leveldb_database.cc

index 5f48cbef60ee2ef17e1377e6c603732f50c9d5e6..7ccc5e3cf67072b80a090256a589347f50a0ad0d 100644

--- a/content/browser/indexed_db/leveldb/leveldb_database.cc

+++ b/content/browser/indexed_db/leveldb/leveldb_database.cc

@@ -184,7 +184,7 @@ static void ParseAndHistogramIOErrorDetails(const std::string& histogram_name,

leveldb_env::MethodID method;

int error = -1;

leveldb_env::ErrorParsingResult result =

- leveldb_env::ParseMethodAndError(s.ToString().c_str(), &method, &error);

+ leveldb_env::ParseMethodAndError(s, &method, &error);

if (result == leveldb_env::NONE)

return;

std::string method_histogram_name(histogram_name);

« no previous file with comments | « no previous file | third_party/leveldatabase/env_chromium.h » ('j') | third_party/leveldatabase/env_chromium.cc » ('J')