Issue 805033002: One more pass at getting half float texture configs correct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 805033002: One more pass at getting half float texture configs correct. (Closed)

Created:
6 years ago by jvanverth1

Modified:
6 years ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

One more pass at getting half float texture configs correct. Added in check for sized internal format. Made choice between RED and ALPHA orthogonal to HALF_FLOAT and HALF_FLOAT_OES. Enabled rendertarget support on ES 2.0. Committed: https://skia.googlesource.com/skia/+/1334c21eee8c5b0b216895934e7a8e1c08c6f510

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -19 lines)			Patch
M	src/gpu/gl/GrGLCaps.cpp	View	1	2 chunks	+13 lines, -6 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1	1 chunk	+15 lines, -8 lines	0 comments	Download
M	tests/FloatingPointTextureTest.cpp	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805033002/20001

6 years ago (2014-12-18 13:36:38 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-18 13:45:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1334c21eee8c5b0b216895934e7a8e1c08c6f510

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages