Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 804993004: [turbofan] Fix unsafe out-of-bounds check for checked loads/stores. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix unsafe out-of-bounds check for checked loads/stores. BUG=chromium:443744 LOG=y TEST=mjsunit/compiler/regress-443744 R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/f7e4689061261fb00660309c7778c124ff0ecca7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -243 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +50 lines, -44 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 4 chunks +165 lines, -191 lines 0 comments Download
A test/mjsunit/compiler/regress-443744.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-19 12:36:32 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-19 12:45:20 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f7e4689061261fb00660309c7778c124ff0ecca7 Cr-Commit-Position: refs/heads/master@{#25901}
6 years ago (2014-12-19 12:53:36 UTC) #4
Benedikt Meurer
6 years ago (2014-12-19 12:53:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f7e4689061261fb00660309c7778c124ff0ecca7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698