Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1834)

Issue 804993003: Fix sandbox target in Windows GN build and enable it. (Closed)

Created:
6 years ago by Slava Chigrin
Modified:
6 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sandbox target in Windows GN build and enable it. Committed: https://crrev.com/fdb4e8d624f1bfe1af5ccfebfa3faa0072caa71d Cr-Commit-Position: refs/heads/master@{#308471}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 1 comment Download
M sandbox/win/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Slava Chigrin
https://codereview.chromium.org/804993003/diff/1/BUILD.gn File BUILD.gn (left): https://codereview.chromium.org/804993003/diff/1/BUILD.gn#oldcode343 BUILD.gn:343: "//sandbox", I don't know, what is better - enable ...
6 years ago (2014-12-15 18:42:15 UTC) #2
cpu_(ooo_6.6-7.5)
your guess is as good as mine. lgtm let me know if you want me ...
6 years ago (2014-12-15 23:18:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804993003/1
6 years ago (2014-12-15 23:29:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 00:23:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fdb4e8d624f1bfe1af5ccfebfa3faa0072caa71d Cr-Commit-Position: refs/heads/master@{#308471}
6 years ago (2014-12-16 00:23:49 UTC) #7
samuong
6 years ago (2014-12-16 00:42:46 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/810623002/ by samuong@chromium.org.

The reason for reverting is: breaks compile step on the win8 gn bot:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/2037.

Powered by Google App Engine
This is Rietveld 408576698