Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Side by Side Diff: src/objects.h

Issue 804993002: Internalize strings being stored into uninitialized property cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 9640 matching lines...) Expand 10 before | Expand all | Expand 10 after
9651 void set_type(HeapType* value, WriteBarrierMode mode = UPDATE_WRITE_BARRIER); 9651 void set_type(HeapType* value, WriteBarrierMode mode = UPDATE_WRITE_BARRIER);
9652 9652
9653 // [dependent_code]: dependent code that depends on the type of the global 9653 // [dependent_code]: dependent code that depends on the type of the global
9654 // property. 9654 // property.
9655 DECL_ACCESSORS(dependent_code, DependentCode) 9655 DECL_ACCESSORS(dependent_code, DependentCode)
9656 9656
9657 // Sets the value of the cell and updates the type field to be the union 9657 // Sets the value of the cell and updates the type field to be the union
9658 // of the cell's current type and the value's type. If the change causes 9658 // of the cell's current type and the value's type. If the change causes
9659 // a change of the type of the cell's contents, code dependent on the cell 9659 // a change of the type of the cell's contents, code dependent on the cell
9660 // will be deoptimized. 9660 // will be deoptimized.
9661 static void SetValueInferType(Handle<PropertyCell> cell, 9661 // Usually returns the value that was passed in, but may perform
9662 Handle<Object> value); 9662 // non-observable modifications on it, such as internalize strings.
9663 static Handle<Object> SetValueInferType(Handle<PropertyCell> cell,
9664 Handle<Object> value);
9663 9665
9664 // Computes the new type of the cell's contents for the given value, but 9666 // Computes the new type of the cell's contents for the given value, but
9665 // without actually modifying the 'type' field. 9667 // without actually modifying the 'type' field.
9666 static Handle<HeapType> UpdatedType(Handle<PropertyCell> cell, 9668 static Handle<HeapType> UpdatedType(Handle<PropertyCell> cell,
9667 Handle<Object> value); 9669 Handle<Object> value);
9668 9670
9669 static void AddDependentCompilationInfo(Handle<PropertyCell> cell, 9671 static void AddDependentCompilationInfo(Handle<PropertyCell> cell,
9670 CompilationInfo* info); 9672 CompilationInfo* info);
9671 9673
9672 DECLARE_CAST(PropertyCell) 9674 DECLARE_CAST(PropertyCell)
(...skipping 1367 matching lines...) Expand 10 before | Expand all | Expand 10 after
11040 } else { 11042 } else {
11041 value &= ~(1 << bit_position); 11043 value &= ~(1 << bit_position);
11042 } 11044 }
11043 return value; 11045 return value;
11044 } 11046 }
11045 }; 11047 };
11046 11048
11047 } } // namespace v8::internal 11049 } } // namespace v8::internal
11048 11050
11049 #endif // V8_OBJECTS_H_ 11051 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/lookup.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698