remove unused openbsd std::isfinite and std::signbit implementations

remove unused openbsd std::isfinite and std::signbit implementations

OpenBSD 4.4 (release 2008) and later include std::isfinite and std::signbit.  

https://bugs.webkit.org/show_bug.cgi?id=19975

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187166

[Mostyn Bramley-Moore, 2014-12-15 09:23:27]

mostynb@opera.com changed reviewers:
+ thakis@chromium.org

[Mostyn Bramley-Moore, 2014-12-15 09:24:47]

@Nico: do you know who (if anyone) to cc on openbsd changes?

[Mostyn Bramley-Moore, 2014-12-15 11:35:24]

CC'ed Landry Breuil, author of the original WebKit patch.

[landry.breuil, 2014-12-15 13:39:58]

On 2014/12/15 11:35:24, Mostyn Bramley-Moore wrote:
> CC'ed Landry Breuil, author of the original WebKit patch.

http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/finite.3?query=is...

yeah, isfinite and signbit are available since 4.4.

[Nico, 2014-12-15 16:10:56]

Thanks!

On 2014/12/15 13:39:58, landry.breuil wrote:
> On 2014/12/15 11:35:24, Mostyn Bramley-Moore wrote:
> > CC'ed Landry Breuil, author of the original WebKit patch.
> 
>
http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/finite.3?query=is...
> 
> yeah, isfinite and signbit are available since 4.4.

4.4 was released Nov 2008, so not supporting earlier OpenBSDs is probably ok?

lgtm, but if this is the only place where we have a bsd 4.3-or-older workaround
and this ends up affecting someone, we might want to put it back in – it's not a
ton of saved code.

[Mostyn Bramley-Moore, 2014-12-15 17:06:07]

On 2014/12/15 16:10:56, Nico wrote:
> 4.4 was released Nov 2008, so not supporting earlier OpenBSDs is probably ok?

I couldn't find a clear statement on the OpenBSD website about release support
windows, but this openbsd-announce message in 2009 implies that even 4.5 has not
had active support since 2009:
http://article.gmane.org/gmane.os.openbsd.announce/149

So I think this is OK, few people if any should be running 4.3 or older.

> lgtm, but if this is the only place where we have a bsd 4.3-or-older
workaround
> and this ends up affecting someone, we might want to put it back in – it's not
a
> ton of saved code.

Sure.

[Mostyn Bramley-Moore, 2014-12-15 17:06:20]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-12-15 17:06:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/804943002/1

[commit-bot: I haz the power, 2014-12-15 19:12:49]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187166

[landry.breuil, 2014-12-15 20:21:47]

On 2014/12/15 17:06:07, Mostyn Bramley-Moore wrote:
> On 2014/12/15 16:10:56, Nico wrote:
> > 4.4 was released Nov 2008, so not supporting earlier OpenBSDs is probably
ok?
> 
> I couldn't find a clear statement on the OpenBSD website about release support
> windows, but this openbsd-announce message in 2009 implies that even 4.5 has
not
> had active support since 2009:
> http://article.gmane.org/gmane.os.openbsd.announce/149
> 
> So I think this is OK, few people if any should be running 4.3 or older.

The support window is a year long, and since we release every 6 months only two
releases are supported at a time. Right now we're at 5.5 and 5.6, so yeah 4.3 is
long-unsupported.

> lgtm, but if this is the only place where we have a bsd 4.3-or-older
workaround

bsd 4.3 from the 90's != openbsd 4.3 from 2008 ! :)