Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 804923002: Move PopupMenuClient.h to core/html/forms (Closed)

Created:
6 years ago by keishi
Modified:
6 years ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering
Project:
blink
Visibility:
Public.

Description

Move PopupMenuClient.h to core/html/forms Moving PopupMenuClient.h to core/html/forms in preparation for https://codereview.chromium.org/736883002/ BUG=346582 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -73 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/core/html/forms/PopupMenuClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/platform/PopupMenuClient.h View 1 chunk +0 lines, -65 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ExternalPopupMenuTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupContainer.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/PopupListBox.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/PopupMenuTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
keishi
6 years ago (2014-12-15 08:31:51 UTC) #2
tkent
lgtm
6 years ago (2014-12-15 08:39:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804923002/1
6 years ago (2014-12-15 08:39:49 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 10:58:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187128

Powered by Google App Engine
This is Rietveld 408576698