Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 804913003: tools: Move Mac-specific tools to tools/mac (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, -1511 lines) Patch
D tools/catch_exception_tool.ad View 1 chunk +0 lines, -117 lines 0 comments Download
D tools/catch_exception_tool.cc View 1 chunk +0 lines, -317 lines 0 comments Download
D tools/exception_port_tool.ad View 1 chunk +0 lines, -187 lines 0 comments Download
D tools/exception_port_tool.cc View 1 chunk +0 lines, -594 lines 0 comments Download
A + tools/mac/catch_exception_tool.ad View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/mac/catch_exception_tool.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/mac/exception_port_tool.ad View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/mac/exception_port_tool.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/mac/on_demand_service_tool.ad View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/mac/on_demand_service_tool.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/on_demand_service_tool.ad View 1 chunk +0 lines, -102 lines 0 comments Download
D tools/on_demand_service_tool.mm View 1 chunk +0 lines, -197 lines 0 comments Download
M tools/tools.gyp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
I left generate_dump alone because my hope is that it will ultimately be a cross-platform ...
6 years ago (2014-12-17 18:59:09 UTC) #2
scottmg
lgtm
6 years ago (2014-12-17 20:24:50 UTC) #3
Mark Mentovai
6 years ago (2014-12-17 20:26:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
39f69c862af6a70c4dec2a772697f32f8d1b6662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698