Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 804853002: Only log voice recognition in always-on hotwording mode. (Closed)

Created:
6 years ago by Anand Mistry (off Chromium)
Modified:
6 years ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only log voice recognition in always-on hotwording mode. BUG=397019 Committed: https://crrev.com/8f9532d1507bbf91ba4ea238e2f849c4c40c886a Cr-Commit-Position: refs/heads/master@{#308318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Mistry (off Chromium)
6 years ago (2014-12-15 00:11:05 UTC) #2
benwells
lgtm
6 years ago (2014-12-15 03:31:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804853002/1
6 years ago (2014-12-15 04:30:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 05:42:29 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 05:43:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f9532d1507bbf91ba4ea238e2f849c4c40c886a
Cr-Commit-Position: refs/heads/master@{#308318}

Powered by Google App Engine
This is Rietveld 408576698