QUIC - enabled FLAGS_allow_truncated_connection_ids_for_quic

chrome/browser/io_thread.h

Index: chrome/browser/io_thread.h
diff --git a/chrome/browser/io_thread.h b/chrome/browser/io_thread.h
index 8f46fc1ec8ab8d9b8d4189570ae37a5666ed5382..09651a64234b81b21ac51d1acea45a35a3d86308 100644
--- a/chrome/browser/io_thread.h
+++ b/chrome/browser/io_thread.h
@@ -194,6 +194,7 @@ class IOThread : public content::BrowserThreadDelegate {
     Optional<int> quic_load_server_info_timeout_ms;
     Optional<bool> quic_disable_loading_server_info_for_new_servers;
     Optional<float> quic_load_server_info_timeout_srtt_multiplier;
+    Optional<bool> quic_disable_truncated_connection_ids;

[Ryan Hamilton, 2015/01/08 22:28:07]

I think we usually use enable_foo for new features. Can you reverse the polarity
to be quic_enable_truncated_connection_ids?

This also means that no field trials groups will use the new code until we
explicitly add a new field trial param which I think is a good idea, but I could
be wrong...?

[ramant (doing other things), 2015/01/08 23:06:58]

Done.

     Optional<size_t> quic_max_packet_length;
     net::QuicTagVector quic_connection_options;
     Optional<std::string> quic_user_agent_id;
@@ -383,6 +384,11 @@ class IOThread : public content::BrowserThreadDelegate {
   static float GetQuicLoadServerInfoTimeoutSrttMultiplier(
       const VariationParameters& quic_trial_params);
 
+  // Returns true if FLAGS_allow_truncated_connection_ids_for_quic should be
+  // disabled.
+  static bool ShouldDisableTruncatedConnectionIds(
+      const VariationParameters& quic_trial_params);
+
   // Returns the maximum length for QUIC packets, based on any flags in
   // |command_line| or the field trial.  Returns 0 if there is an error
   // parsing any of the options, or if the default value should be used.