QUIC - enabled FLAGS_allow_truncated_connection_ids_for_quic

net/quic/quic_stream_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_stream_factory.h"
 
 #include <set>
 
 #include "base/cpu.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
+#include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/rand_util.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "net/base/net_errors.h"
 #include "net/cert/cert_verifier.h"
 #include "net/dns/host_resolver.h"
 #include "net/dns/single_request_host_resolver.h"
 #include "net/http/http_server_properties.h"
 #include "net/quic/congestion_control/tcp_receiver.h"
 #include "net/quic/crypto/channel_id_chromium.h"
 #include "net/quic/crypto/proof_verifier_chromium.h"
 #include "net/quic/crypto/quic_random.h"
 #include "net/quic/crypto/quic_server_info.h"
 #include "net/quic/port_suggester.h"
 #include "net/quic/quic_client_session.h"
 #include "net/quic/quic_clock.h"
 #include "net/quic/quic_connection.h"
 #include "net/quic/quic_connection_helper.h"
 #include "net/quic/quic_crypto_client_stream_factory.h"
 #include "net/quic/quic_default_packet_writer.h"
+#include "net/quic/quic_flags.h"
 #include "net/quic/quic_http_stream.h"
 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_server_id.h"
 #include "net/socket/client_socket_factory.h"
 
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"
 #endif
 
 namespace net {
@@ skipping 32 matching lines @@
 
   return true;
 }
 
 QuicConfig InitializeQuicConfig(const QuicTagVector& connection_options) {
   QuicConfig config;
   config.SetIdleConnectionStateLifetime(
       QuicTime::Delta::FromSeconds(kIdleConnectionTimeoutSeconds),
       QuicTime::Delta::FromSeconds(kIdleConnectionTimeoutSeconds));
   config.SetConnectionOptionsToSend(connection_options);
+
+  // TODO(rtenneti): Delete the following enabling of
+  // FLAGS_allow_truncated_connection_ids_for_quic code when the flag is enabled
+  // by default.

[Ryan Hamilton, 2015/01/07 23:10:23]

I think it would be better to make this finch controlled so that we can turn it
off if there are any problems. What do you think?

I thought we also decided to set the FLAG to true by default?

[ramant (doing other things), 2015/01/08 02:54:51]

Done.

+  CR_DEFINE_STATIC_LOCAL(scoped_refptr<base::FieldTrial>, trial, ());
+  if (!trial.get()) {
+    // Set up a field trial to enable
+    // FLAGS_allow_truncated_connection_ids_for_quic for 50% of the users.
+    trial = base::FieldTrialList::FactoryGetFieldTrial(
+        "QuicConnection", 100, "allow_truncated_connection_ids", 2015, 1, 31,
+        base::FieldTrial::SESSION_RANDOMIZED, NULL);
+    int allow_truncated_connection_ids_group =
+        trial->AppendGroup("truncated_connection_ids", 50);
+    if (trial->group() == allow_truncated_connection_ids_group)
+      FLAGS_allow_truncated_connection_ids_for_quic = true;
+  }
+  if (FLAGS_allow_truncated_connection_ids_for_quic)
+    config.SetBytesForConnectionIdToSend(0);
+
   return config;
 }
 
 class DefaultPacketWriterFactory : public QuicConnection::PacketWriterFactory {
  public:
   explicit DefaultPacketWriterFactory(DatagramClientSocket* socket)
       : socket_(socket) {}
   ~DefaultPacketWriterFactory() override {}
 
   QuicPacketWriter* Create(QuicConnection* connection) const override;
@@ skipping 1082 matching lines @@
   http_server_properties_->ClearAlternateProtocol(server);
   http_server_properties_->SetAlternateProtocol(
       server, alternate.port, alternate.protocol, 1);
   DCHECK_EQ(QUIC,
             http_server_properties_->GetAlternateProtocol(server).protocol);
   DCHECK(http_server_properties_->WasAlternateProtocolRecentlyBroken(
       server));
 }
 
 }  // namespace net