Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 804773004: [WebCrypto] OperationError instead of DataError when publicExponent for RSA key generation is not … (Closed)

Created:
6 years ago by Habib Virji
Modified:
6 years ago
Reviewers:
eroman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebCrypto] OperationError instead of DataError when publicExponent for RSA key generation is not in supported range Currently data error is thrown, but as per spec it should throw OperationError. BUG=441876 R=eroman Committed: https://crrev.com/d6e19c90b5960d6ea3913149ce88b5f333f92dc5 Cr-Commit-Position: refs/heads/master@{#309238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/webcrypto/status.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
eroman
LGTM provided the LayoutTests pass
6 years ago (2014-12-18 20:38:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804773004/1
6 years ago (2014-12-19 18:28:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 19:59:54 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-19 20:01:32 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6e19c90b5960d6ea3913149ce88b5f333f92dc5
Cr-Commit-Position: refs/heads/master@{#309238}

Powered by Google App Engine
This is Rietveld 408576698