Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 804753005: [Android] Rename [Chromium -> Chrome]NativeTestInstrumentationTestRunner. (Closed)

Created:
5 years, 11 months ago by jbudorick
Modified:
5 years, 11 months ago
Reviewers:
Ted C, cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Rename [Chromium -> Chrome]NativeTestInstrumentationTestRunner. Motivated by http://www.chromium.org/developers/coding-style#Naming BUG=428729 Committed: https://crrev.com/7b40b73fea4cad08630bb87caeee64c5a8a061fe Cr-Commit-Position: refs/heads/master@{#310877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -199 lines) Patch
M build/android/pylib/remote/device/remote_device_gtest_run.py View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
A + testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 1 chunk +2 lines, -2 lines 0 comments Download
D testing/android/java/src/org/chromium/native_test/ChromiumNativeTestInstrumentationTestRunner.java View 1 chunk +0 lines, -193 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jbudorick
5 years, 11 months ago (2015-01-08 14:39:35 UTC) #2
Ted C
lgtm
5 years, 11 months ago (2015-01-09 19:49:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804753005/1
5 years, 11 months ago (2015-01-09 19:50:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/34648)
5 years, 11 months ago (2015-01-09 20:02:34 UTC) #7
jbudorick
+cjhopman for build/config/android/rules.gni
5 years, 11 months ago (2015-01-09 20:08:01 UTC) #9
cjhopman
I'd probably just totally drop the Chrome/Chromium from the name. Either way lgtm.
5 years, 11 months ago (2015-01-09 22:11:54 UTC) #10
jbudorick
On 2015/01/09 22:11:54, cjhopman wrote: > I'd probably just totally drop the Chrome/Chromium from the ...
5 years, 11 months ago (2015-01-09 22:49:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804753005/1
5 years, 11 months ago (2015-01-09 22:51:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 22:57:12 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 22:59:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b40b73fea4cad08630bb87caeee64c5a8a061fe
Cr-Commit-Position: refs/heads/master@{#310877}

Powered by Google App Engine
This is Rietveld 408576698